Table of Contents
回复讨论(解决方案)

怎么简写代码

Jun 23, 2016 pm 02:38 PM

if($_MODULE[huoqubaobei]=="2"){$arr = explode(',',$_MODULE[item_1]);  foreach($arr as $value){		  		   $item=$itemManager-> queryById ($value);		       $itemUrl = $uriManager->detailURI($item);                 $itemPicUrl = $item->getPicUrl(160);               $itemTitle = $item->title;                 $itemPrice = $item->price;                $itemsoldCount = $item->soldCount;								echo $itemUrl;				echo $itemPicUrl;				echo $itemTitle;				echo $itemPrice;				echo $itemsoldCount;						   }}else if($_MODULE[huoqubaobei]=="1"){		  $items=$itemManager->queryByKeyword("","hotsell",9);			 				  foreach($items as $item ){							       $itemUrl = $uriManager->detailURI($item);                 $itemPicUrl = $item->getPicUrl(160);               $itemTitle = $item->title;                 $itemPrice = $item->price;                $itemsoldCount = $item->soldCount; 					echo $itemUrl;				echo $itemPicUrl;				echo $itemTitle;				echo $itemPrice;				echo $itemsoldCount; 				   }}else if($_MODULE[huoqubaobei]=="3"){	   $items = $itemManager->queryByCategory($categoryId,"hotsell",10);     foreach($items as $item){		       $itemUrl = $uriManager->detailURI($item);                 $itemPicUrl = $item->getPicUrl(160);               $itemTitle = $item->title;                 $itemPrice = $item->price;                $itemsoldCount = $item->soldCount; 					echo $itemUrl;				echo $itemPicUrl;				echo $itemTitle;				echo $itemPrice;				echo $itemsoldCount;		 }}else{	     $itemUrl ="#";                 $itemPicUrl = "assets/images/nvtp.jpg";               $itemTitle = "请添加宝贝描述请添加宝贝描述请添加宝贝描述请";                 $itemPrice = 628;                $itemsoldCount =89; 					echo $itemUrl;				echo $itemPicUrl;				echo $itemTitle;				echo $itemPrice;				echo $itemsoldCount;}
Copy after login


怎么简写哈
echo $itemPicUrl;
echo $itemTitle;
echo $itemPrice;
echo $itemsoldCount;
怎么不让他们重复写

我本来想都加到数组里 然后循环 但这样运行性能不行 谁有更好的方法




回复讨论(解决方案)

你在每个分支里输出同样的一组变量?
为何不在条件结构出来后在输出?

if($_MODULE[huoqubaobei]=="2"){	$arr = explode(',',$_MODULE[item_1]);	foreach($arr as $value)	{	    $items=$itemManager-> queryById ($value);    }}elseif($_MODULE[huoqubaobei]=="1"){      $items=$itemManager->queryByKeyword("","hotsell",9);}elseif($_MODULE[huoqubaobei]=="3"){      $items = $itemManager->queryByCategory($categoryId,"hotsell",10);}if($items) {	foreach($items as $item)	{	    $itemUrl = $uriManager->detailURI($item); 		$itemPicUrl = $item->getPicUrl(160);	    $itemTitle = $item->title;		$itemPrice = $item->price;		$itemsoldCount = $item->soldCount; 		echo $itemUrl;		echo $itemPicUrl;		echo $itemTitle;		echo $itemPrice;		echo $itemsoldCount;	 }}else{	$itemUrl ="#";     $itemPicUrl = "assets/images/nvtp.jpg";    $itemTitle = "请添加宝贝描述请添加宝贝描述请添加宝贝描述请";	$itemPrice = 628;	$itemsoldCount =89; 	echo $itemUrl;	echo $itemPicUrl;	echo $itemTitle;	echo $itemPrice;	echo $itemsoldCount;}
Copy after login
Copy after login
Copy after login

if($_MODULE[huoqubaobei]=="2"){	$arr = explode(',',$_MODULE[item_1]);	foreach($arr as $value)	{	    $items=$itemManager-> queryById ($value);    }}elseif($_MODULE[huoqubaobei]=="1"){      $items=$itemManager->queryByKeyword("","hotsell",9);}elseif($_MODULE[huoqubaobei]=="3"){      $items = $itemManager->queryByCategory($categoryId,"hotsell",10);}if($items) {	foreach($items as $item)	{	    $itemUrl = $uriManager->detailURI($item); 		$itemPicUrl = $item->getPicUrl(160);	    $itemTitle = $item->title;		$itemPrice = $item->price;		$itemsoldCount = $item->soldCount; 		echo $itemUrl;		echo $itemPicUrl;		echo $itemTitle;		echo $itemPrice;		echo $itemsoldCount;	 }}else{	$itemUrl ="#";     $itemPicUrl = "assets/images/nvtp.jpg";    $itemTitle = "请添加宝贝描述请添加宝贝描述请添加宝贝描述请";	$itemPrice = 628;	$itemsoldCount =89; 	echo $itemUrl;	echo $itemPicUrl;	echo $itemTitle;	echo $itemPrice;	echo $itemsoldCount;}
Copy after login
Copy after login
Copy after login


哈哈 你还是重复了 最后面

if($_MODULE[huoqubaobei]=="2"){	$arr = explode(',',$_MODULE[item_1]);	foreach($arr as $value)	{	    $items=$itemManager-> queryById ($value);    }}elseif($_MODULE[huoqubaobei]=="1"){      $items=$itemManager->queryByKeyword("","hotsell",9);}elseif($_MODULE[huoqubaobei]=="3"){      $items = $itemManager->queryByCategory($categoryId,"hotsell",10);}if($items) {	foreach($items as $item)	{	    $itemUrl = $uriManager->detailURI($item); 		$itemPicUrl = $item->getPicUrl(160);	    $itemTitle = $item->title;		$itemPrice = $item->price;		$itemsoldCount = $item->soldCount; 		echo $itemUrl;		echo $itemPicUrl;		echo $itemTitle;		echo $itemPrice;		echo $itemsoldCount;	 }}else{	$itemUrl ="#";     $itemPicUrl = "assets/images/nvtp.jpg";    $itemTitle = "请添加宝贝描述请添加宝贝描述请添加宝贝描述请";	$itemPrice = 628;	$itemsoldCount =89; 	echo $itemUrl;	echo $itemPicUrl;	echo $itemTitle;	echo $itemPrice;	echo $itemsoldCount;}
Copy after login
Copy after login
Copy after login

而且 我最后面的else 其实是elseif($_MODULE[huoqubaobei]=="4")

你在每个分支里输出同样的一组变量?
为何不在条件结构出来后在输出? 不明白你的意思。。。


你在每个分支里输出同样的一组变量?
为何不在条件结构出来后在输出? 不明白你的意思。。。

意思就是,你看每?if else?面都有
echo $itemUrl;
echo $itemPicUrl;
echo $itemTitle;
echo $itemPrice;
echo $itemsoldCount;
可以在?束位置加上,不需要在每?if else?面?。

	$response= '';	switch($_MODULE[huoqubaobei]){		case "2":			$arr = explode(',',$_MODULE[item_1]);			foreach($arr as $value){				$item=$itemManager-> queryById ($value);				$items = array_push($items, $item);			}		case "1":			$items = $itemManager->queryByKeyword("","hotsell",9);		case "3":			$items = $itemManager->queryByCategory($categoryId,"hotsell",10);		default:			$items = array();	}	if($items){		foreach($items as $item){			$itemUrl = $uriManager->detailURI($item); 			$itemPicUrl = $item->getPicUrl(160);			$itemTitle = $item->title;			$itemPrice = $item->price;			$itemsoldCount = $item->soldCount; 			$response .= $itemUrl.$itemPicUrl.$itemTitle.$itemPrice.$itemsoldCount		}	}else{			$itemUrl ="#"; 			$itemPicUrl = "assets/images/nvtp.jpg";			$itemTitle = "请添加宝贝描述请添加宝贝描述请添加宝贝描述请";			$itemPrice = 628;			$itemsoldCount =89;			$response .= $itemUrl.$itemPicUrl.$itemTitle.$itemPrice.$itemsoldCount	}	echo $response;
Copy after login

修改了一下,??才?。

	$response= '';	$items = array();	switch($_MODULE[huoqubaobei]){		case "2":			$arr = explode(',',$_MODULE[item_1]);			foreach($arr as $value){				$item=$itemManager-> queryById ($value);				array_push($items, $item);			}		case "1":			$items = $itemManager->queryByKeyword("","hotsell",9);		case "3":			$items = $itemManager->queryByCategory($categoryId,"hotsell",10);	}	if($items){		foreach($items as $item){			$itemUrl = $uriManager->detailURI($item); 			$itemPicUrl = $item->getPicUrl(160);			$itemTitle = $item->title;			$itemPrice = $item->price;			$itemsoldCount = $item->soldCount; 			$response .= $itemUrl.$itemPicUrl.$itemTitle.$itemPrice.$itemsoldCount		}	}else{			$itemUrl ="#"; 			$itemPicUrl = "assets/images/nvtp.jpg";			$itemTitle = "请添加宝贝描述请添加宝贝描述请添加宝贝描述请";			$itemPrice = 628;			$itemsoldCount =89;			$response .= $itemUrl.$itemPicUrl.$itemTitle.$itemPrice.$itemsoldCount	}	echo $response;
Copy after login
Copy after login

这段代码其实应该写成类并继承$itemManager的类(或组成对象链)会更好

1、形如

echo $itemUrl;echo $itemPicUrl;echo $itemTitle;echo $itemPrice;echo $itemsoldCount;
Copy after login
Copy after login
的可简化为
show($itemUrl, $itemPicUrl, $itemTitle, $itemPrice, $itemsoldCount);function show() {  echo join('', func_get_args());}
Copy after login
Copy after login
函数 show 中可做各种美化工作

2、原式就可写作
if($_MODULE[huoqubaobei]=="2"){$arr = explode(',',$_MODULE[item_1]);	 foreach($arr as $value){		$item=$itemManager-> queryById ($value);		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}else if($_MODULE[huoqubaobei]=="1"){	$items=$itemManager->queryByKeyword("","hotsell",9);	foreach($items as $item ){		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}else if($_MODULE[huoqubaobei]=="3"){	$items = $itemManager->queryByCategory($categoryId,"hotsell",10);	foreach($items as $item){		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}else{	show("#",		"assets/images/nvtp.jpg",		"请添加宝贝描述请添加宝贝描述请添加宝贝描述请",		628,		89,		);}
Copy after login
Copy after login


3、考虑到前三个分支存在相同的取数方法,于是可以再写一个函数
function item_show($items, $uriManager) {	foreach($items as $item){		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}
Copy after login
Copy after login


4、代码就进一步变为
if($_MODULE[huoqubaobei]=="2"){$arr = explode(',',$_MODULE[item_1]);	 foreach($arr as $value){		items_show(array($itemManager->queryById($value)), $uriManager);	}}else if($_MODULE[huoqubaobei]=="1"){	items_show($itemManager->queryByKeyword("","hotsell",9), , $uriManager);}else if($_MODULE[huoqubaobei]=="3"){	items_show($itemManager->queryByCategory($categoryId,"hotsell",10), $uriManager);}else{	show("#",		"assets/images/nvtp.jpg",		"请添加宝贝描述请添加宝贝描述请添加宝贝描述请",		628,		89,		);}function show() {	echo join('', func_get_args());}function items_show($items, $uriManager) {	foreach($items as $item){		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}
Copy after login
Copy after login

哈哈 最后一楼是对的

修改了一下,??才?。

	$response= '';	$items = array();	switch($_MODULE[huoqubaobei]){		case "2":			$arr = explode(',',$_MODULE[item_1]);			foreach($arr as $value){				$item=$itemManager-> queryById ($value);				array_push($items, $item);			}		case "1":			$items = $itemManager->queryByKeyword("","hotsell",9);		case "3":			$items = $itemManager->queryByCategory($categoryId,"hotsell",10);	}	if($items){		foreach($items as $item){			$itemUrl = $uriManager->detailURI($item); 			$itemPicUrl = $item->getPicUrl(160);			$itemTitle = $item->title;			$itemPrice = $item->price;			$itemsoldCount = $item->soldCount; 			$response .= $itemUrl.$itemPicUrl.$itemTitle.$itemPrice.$itemsoldCount		}	}else{			$itemUrl ="#"; 			$itemPicUrl = "assets/images/nvtp.jpg";			$itemTitle = "请添加宝贝描述请添加宝贝描述请添加宝贝描述请";			$itemPrice = 628;			$itemsoldCount =89;			$response .= $itemUrl.$itemPicUrl.$itemTitle.$itemPrice.$itemsoldCount	}	echo $response;
Copy after login
Copy after login


$itemUrl ="#";
$itemPicUrl = "assets/images/nvtp.jpg";
$itemTitle = "请添加宝贝描述请添加宝贝描述请添加宝贝描述请";
$itemPrice = 628;
$itemsoldCount =89;
$response .= $itemUrl.$itemPicUrl.$itemTitle.$itemPrice.$itemsoldCount
怎么写到循环上

最後一?情?不是不用循???
如果要循?,需要提供循?的次?。

最後一?情?不是不用循???
如果要循?,需要提供循?的次?。

foreach($items as $item){ 次数跟他一样

最后一?情?,你的items都?有?取,如何循??

最后一?情?,你的items都?有?取,如何循??

其实他前面if($items)判断是不对的不能这样判断

我最后面是else if($_MODULE[huoqubaobei]=="4") 判断的

没看到有什么东西要循环的。。
else
{
$itemUrl ="#";
$itemPicUrl = "assets/images/nvtp.jpg";
$itemTitle = "请添加宝贝描述请添加宝贝描述请添加宝贝描述请";
$itemPrice = 628;
$itemsoldCount =89;
echo $itemUrl;
echo $itemPicUrl;
echo $itemTitle;
echo $itemPrice;
echo $itemsoldCount;
}

1、形如

echo $itemUrl;echo $itemPicUrl;echo $itemTitle;echo $itemPrice;echo $itemsoldCount;
Copy after login
Copy after login
的可简化为
show($itemUrl, $itemPicUrl, $itemTitle, $itemPrice, $itemsoldCount);function show() {  echo join('', func_get_args());}
Copy after login
Copy after login
函数 show 中可做各种美化工作

2、原式就可写作
if($_MODULE[huoqubaobei]=="2"){$arr = explode(',',$_MODULE[item_1]);	 foreach($arr as $value){		$item=$itemManager-> queryById ($value);		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}else if($_MODULE[huoqubaobei]=="1"){	$items=$itemManager->queryByKeyword("","hotsell",9);	foreach($items as $item ){		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}else if($_MODULE[huoqubaobei]=="3"){	$items = $itemManager->queryByCategory($categoryId,"hotsell",10);	foreach($items as $item){		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}else{	show("#",		"assets/images/nvtp.jpg",		"请添加宝贝描述请添加宝贝描述请添加宝贝描述请",		628,		89,		);}
Copy after login
Copy after login


3、考虑到前三个分支存在相同的取数方法,于是可以再写一个函数
function item_show($items, $uriManager) {	foreach($items as $item){		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}
Copy after login
Copy after login


4、代码就进一步变为
if($_MODULE[huoqubaobei]=="2"){$arr = explode(',',$_MODULE[item_1]);	 foreach($arr as $value){		items_show(array($itemManager->queryById($value)), $uriManager);	}}else if($_MODULE[huoqubaobei]=="1"){	items_show($itemManager->queryByKeyword("","hotsell",9), , $uriManager);}else if($_MODULE[huoqubaobei]=="3"){	items_show($itemManager->queryByCategory($categoryId,"hotsell",10), $uriManager);}else{	show("#",		"assets/images/nvtp.jpg",		"请添加宝贝描述请添加宝贝描述请添加宝贝描述请",		628,		89,		);}function show() {	echo join('', func_get_args());}function items_show($items, $uriManager) {	foreach($items as $item){		show($uriManager->detailURI($item),			$item->getPicUrl(160),			$item->title,			$item->price,			$item->soldCount			);	}}
Copy after login
Copy after login


这段才是最省事的!

还可以这样写~  


你在每个分支里输出同样的一组变量?
为何不在条件结构出来后在输出? 不明白你的意思。。。

把那些变量的地方都放到外面来

Statement of this Website
The content of this article is voluntarily contributed by netizens, and the copyright belongs to the original author. This site does not assume corresponding legal responsibility. If you find any content suspected of plagiarism or infringement, please contact admin@php.cn

Hot AI Tools

Undresser.AI Undress

Undresser.AI Undress

AI-powered app for creating realistic nude photos

AI Clothes Remover

AI Clothes Remover

Online AI tool for removing clothes from photos.

Undress AI Tool

Undress AI Tool

Undress images for free

Clothoff.io

Clothoff.io

AI clothes remover

AI Hentai Generator

AI Hentai Generator

Generate AI Hentai for free.

Hot Article

R.E.P.O. Energy Crystals Explained and What They Do (Yellow Crystal)
3 weeks ago By 尊渡假赌尊渡假赌尊渡假赌
R.E.P.O. Best Graphic Settings
3 weeks ago By 尊渡假赌尊渡假赌尊渡假赌
R.E.P.O. How to Fix Audio if You Can't Hear Anyone
3 weeks ago By 尊渡假赌尊渡假赌尊渡假赌

Hot Tools

Notepad++7.3.1

Notepad++7.3.1

Easy-to-use and free code editor

SublimeText3 Chinese version

SublimeText3 Chinese version

Chinese version, very easy to use

Zend Studio 13.0.1

Zend Studio 13.0.1

Powerful PHP integrated development environment

Dreamweaver CS6

Dreamweaver CS6

Visual web development tools

SublimeText3 Mac version

SublimeText3 Mac version

God-level code editing software (SublimeText3)

Working with Flash Session Data in Laravel Working with Flash Session Data in Laravel Mar 12, 2025 pm 05:08 PM

Laravel simplifies handling temporary session data using its intuitive flash methods. This is perfect for displaying brief messages, alerts, or notifications within your application. Data persists only for the subsequent request by default: $request-

cURL in PHP: How to Use the PHP cURL Extension in REST APIs cURL in PHP: How to Use the PHP cURL Extension in REST APIs Mar 14, 2025 am 11:42 AM

The PHP Client URL (cURL) extension is a powerful tool for developers, enabling seamless interaction with remote servers and REST APIs. By leveraging libcurl, a well-respected multi-protocol file transfer library, PHP cURL facilitates efficient execution of various network protocols, including HTTP, HTTPS, and FTP. This extension offers granular control over HTTP requests, supports multiple concurrent operations, and provides built-in security features.

Simplified HTTP Response Mocking in Laravel Tests Simplified HTTP Response Mocking in Laravel Tests Mar 12, 2025 pm 05:09 PM

Laravel provides concise HTTP response simulation syntax, simplifying HTTP interaction testing. This approach significantly reduces code redundancy while making your test simulation more intuitive. The basic implementation provides a variety of response type shortcuts: use Illuminate\Support\Facades\Http; Http::fake([ 'google.com' => 'Hello World', 'github.com' => ['foo' => 'bar'], 'forge.laravel.com' =>

PHP Logging: Best Practices for PHP Log Analysis PHP Logging: Best Practices for PHP Log Analysis Mar 10, 2025 pm 02:32 PM

PHP logging is essential for monitoring and debugging web applications, as well as capturing critical events, errors, and runtime behavior. It provides valuable insights into system performance, helps identify issues, and supports faster troubleshoot

12 Best PHP Chat Scripts on CodeCanyon 12 Best PHP Chat Scripts on CodeCanyon Mar 13, 2025 pm 12:08 PM

Do you want to provide real-time, instant solutions to your customers' most pressing problems? Live chat lets you have real-time conversations with customers and resolve their problems instantly. It allows you to provide faster service to your custom

Explain the concept of late static binding in PHP. Explain the concept of late static binding in PHP. Mar 21, 2025 pm 01:33 PM

Article discusses late static binding (LSB) in PHP, introduced in PHP 5.3, allowing runtime resolution of static method calls for more flexible inheritance.Main issue: LSB vs. traditional polymorphism; LSB's practical applications and potential perfo

Customizing/Extending Frameworks: How to add custom functionality. Customizing/Extending Frameworks: How to add custom functionality. Mar 28, 2025 pm 05:12 PM

The article discusses adding custom functionality to frameworks, focusing on understanding architecture, identifying extension points, and best practices for integration and debugging.

See all articles