How to pass WaitGroup to sequential function call?
I have a function that can be called sequentially or concurrently in separate goroutines.
I want to ensure that the function is fully executed before the main goroutine completes, so I pass the *sync.waitgroup parameter to the function. Now, in some places the function will be called sequentially.
I can pass nil waitgroup to the function like this:
func my_func(wg *sync.WaitGroup){ if wg != nil{ defer wg.Done() } // do the task } func main(){ my_func(nil) // sequential call wg := sync.WaitGroup{} wg.Add(1) go my_func(&wg) // concurrent call wg.Wait() }
Is there a better way to achieve this goal?
Correct answer
Your my_func()
should not know/should not care how it is executed (whether in a new goroutine or not middle). Therefore, you should not pass wg
for this. Don't force concurrent or non-concurrent use of your api, let users of your package decide how they want to call it.
If anyone wishes to run it simultaneously, in a new goroutine, this can be done outside
of my_func() as shown below :
<div class="code" style="position:relative; padding:0px; margin:0px;"><pre class='brush:php;toolbar:false;'>wg.add(1)
go func() {
defer wg.done()
my_func()
}()</pre><div class="contentsignin">Copy after login</div></div>
This also makes it possible to place more code before/after function calls that will be executed before the
call:
<div class="code" style="position:relative; padding:0px; margin:0px;"><pre class='brush:php;toolbar:false;'>wg.add(1)
go func() {
defer wg.done()
// other code before
my_func()
// other code after
}()</pre><div class="contentsignin">Copy after login</div></div>
Also note that if you have this functionality in many places, you can create a helper function that takes care of goroutine startup and waitgroup handling:
func launchmyfunc(wg *sync.waitgroup) { go func() { defer wg.done() my_func() }() }
You can also create a helper that accepts any parameterless and returnless function:
func launchfunc(wg *sync.waitgroup, f func()) { go func() { defer wg.done() f() }() }
Using the helpers above, you can do this:
wg.Add(1) launchMyFunc(wg) // or wg.Add(1) launchFunc(wg, my_func)
The above is the detailed content of How to pass WaitGroup to sequential function call?. For more information, please follow other related articles on the PHP Chinese website!

Hot AI Tools

Undresser.AI Undress
AI-powered app for creating realistic nude photos

AI Clothes Remover
Online AI tool for removing clothes from photos.

Undress AI Tool
Undress images for free

Clothoff.io
AI clothes remover

AI Hentai Generator
Generate AI Hentai for free.

Hot Article

Hot Tools

Notepad++7.3.1
Easy-to-use and free code editor

SublimeText3 Chinese version
Chinese version, very easy to use

Zend Studio 13.0.1
Powerful PHP integrated development environment

Dreamweaver CS6
Visual web development tools

SublimeText3 Mac version
God-level code editing software (SublimeText3)

Hot Topics

This article explains Go's package import mechanisms: named imports (e.g., import "fmt") and blank imports (e.g., import _ "fmt"). Named imports make package contents accessible, while blank imports only execute t

This article explains Beego's NewFlash() function for inter-page data transfer in web applications. It focuses on using NewFlash() to display temporary messages (success, error, warning) between controllers, leveraging the session mechanism. Limita

This article details efficient conversion of MySQL query results into Go struct slices. It emphasizes using database/sql's Scan method for optimal performance, avoiding manual parsing. Best practices for struct field mapping using db tags and robus

This article explores Go's custom type constraints for generics. It details how interfaces define minimum type requirements for generic functions, improving type safety and code reusability. The article also discusses limitations and best practices

This article demonstrates creating mocks and stubs in Go for unit testing. It emphasizes using interfaces, provides examples of mock implementations, and discusses best practices like keeping mocks focused and using assertion libraries. The articl

This article details efficient file writing in Go, comparing os.WriteFile (suitable for small files) with os.OpenFile and buffered writes (optimal for large files). It emphasizes robust error handling, using defer, and checking for specific errors.

The article discusses writing unit tests in Go, covering best practices, mocking techniques, and tools for efficient test management.

This article explores using tracing tools to analyze Go application execution flow. It discusses manual and automatic instrumentation techniques, comparing tools like Jaeger, Zipkin, and OpenTelemetry, and highlighting effective data visualization
