第一次程式碼審查-js教程-PHP中文網

昨天，我的程式碼第一次被其他人審查。作為我正在參加的開源開發課程的作業之一，我們必須審查彼此的程式碼。在這個練習中，我與 Vinh 搭檔，他是我的一個朋友，碰巧也是一位非常優秀的程式設計師。我們的任務是測試和歸檔彼此在課程中一直在使用的命令列工具工作的問題。

Vinh Nhan

/維尼揚

非同步與同步方法

我們透過文字同步和透過 GitHub 問題非同步進行程式碼審查。我發現同步方法可以更快地得到結果，因為我可以諮詢程式碼作者，了解他們在編寫程式碼時為什麼採用某種方法，並立即得到答案。然而，非同步方法消除了在兩個人的日程安排中找到固定時間來完成工作的需要。

測試 Vinh 的程序

Vinh 創建了一個名為「barrierless」的命令列工具，它使用人工智慧將文字短語翻譯成其他語言，我認為這是一個很酷的主意。當我開始測試 Vinh 的程式時，它還處於早期開發階段，所以還沒有 README（現在有了，去看看吧！）。

維尼揚 / 無障礙的

什麼是無障礙

Barrierless 是一款命令列工具，旨在透過提供從一種語言到另一種語言的無縫翻譯來打破語言障礙。該工具由 GROQCloud 提供支持，允許用戶快速將文字翻譯成所需的目標語言，使不同語言之間的溝通變得輕鬆。

特點

自動偵測語言。
多語言支援：在多種語言之間翻譯文字。
GROQCloud 整合：利用 GROQCloud 的高效能翻譯 API。
易於使用：簡單的命令列介面，可快速翻譯。
可自訂：可輕鬆擴充以取得其他語言功能或 API 支援。

使用方法

安裝

git clone git@github.com:vinhyan/barrierless.git

登入後複製

cd barrierless

登入後複製

安裝所需的依賴項：

npm install

登入後複製

建立一個 .env 檔案來儲存 Groq API 金鑰
注意：有關如何取得和儲存 Groq API Key 的說明，請參閱 .env.example
如果在步驟 3 中使用了 npm install -g 則省略此步驟...

在 GitHub 上查看

A feature I really liked is the colorful output text which makes the user experience a little bit more pleasant - something I neglected in my own program in trying to model it after CLI tools like git.

I read the package.json file to find out how the program should be run, and when it immediately crashed I realized I forgot to add the API key as an environment variable. After adding my API key, the program ran without errors, although I did find an interesting quirk - the program defaults the output language to English, so if you didn't specify one, and the input was in English, it seemed to choose a language to translate to on its own - either randomly, or based on context from the input.

First code review

I opened a few other issues, mostly to do with improving code quality:

A missing try/catch block around an async function call

Uncaught exception in index.js #7

uday-rana posted on Sep 12, 2024

index.js contains the following async function calls which are not wrapped in a try/catch block and may lead to an uncaught exception:

export async function main(text, targetLang) {
  const chatCompletion = await getGroqChatCompletion(text, targetLang);
  console.log(chatCompletion.choices[0]?.message?.content || '');
}

...

program
  ...
  .action(async (text, options) => {
    console.log(chalk.blue(`Translating  <span class="pl-s1"><span class="pl-kos">${text}</span>...`</span>));

    await main(text, options.language);
  });登入後複製

    Enter fullscreen mode
    


    Exit fullscreen mode
    

View on GitHub

Some suggestions to make code easier to understand

Could simplify code #8

uday-rana posted on Sep 12, 2024

Some changes may be made to to the project make it easier to understand and work on:

[x] Move Groq configuration above program initialization with commander
[x] main() seems unnecessary since it contains two lines of code and there are more lines of code involved in creating and invoking the function than if it was omitted
[ ] prompt.js seems unnecessary since it just contains a single function which places arguments into a template literal and returns them
[x] Exporting main() and getGroqChatCompletion() seems unnecessary

View on GitHub